hotel-manage-stack/tablet-checkin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix NewBook write mechanism, bundle push extension, remove vestigial hotel_id

Browse source 
- setBookingCustomFields: use bookings_update's own custom_fields array
  (confirmed from the real legacy plugin code) instead of
  instance_custom_fields_set, which was only ever proven for a different,
  unrelated plugin
- online_checkin_complete is now a configurable per-hotel custom field
  (online_checkin_complete_custom_field_id setting), not a bogus top-level
  bookings_update field NewBook would silently ignore
- Fix field-name mismatches vs a real live NewBook booking response:
  booking_arrival/departure/length, guest address (street/city/state/
  postcode/country, not a single field), phone/mobile (in contact_details,
  not top-level), and pickPrimaryGuest now checks primary_client (was
  checking fields that don't exist in the real API)
- Bundle the standalone push extension into backend/extension-src/, add
  GET /api/extension/download (zips on request via archiver) and a
  download button on the Settings page
- Remove newbook_hotel_id — vestigial from the legacy system's multi-hotel
  routing model, never actually reached NewBook's API, this stack is
  single-hotel-per-deployment so there's nothing to route between

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
jtricerolph 2026-09-01 18:11:35 +00:00
parent 3b2e25df3f
commit 4d3774ef0d
25 changed files with 3557 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

11
backend/src/lib/push.js
View file

@ -1,5 +1,5 @@
import { randomBytes } from 'crypto'
import { pool, getSetting } from '../db.js'
import { pool } from '../db.js'
import { pushNavigate } from './device-stream.js'
const SESSION_TTL_MINUTES = 30
@ -24,7 +24,14 @@ export async function pushBookingToDevice(deviceId, bookingId) {
return { ok: false, status: 409, error: `${existing[0].name} is busy with another check-in` }
}
const hotelId = (await getSetting('newbook_hotel_id', '')) || process.env.NEWBOOK_LOCATION_ID || ''
// Single-hotel-per-stack deployment (see project_checkin memory) — no
// per-request "which hotel" lookup needed, this whole app instance already
// is one hotel. hotel_id here is purely a local audit-row label, sourced
// from the same env var lib/newbook.js sends to the NewBook API itself
// (not a separate app-level setting — a local `newbook_hotel_id` Settings
// field existed here before 2026-09-01 but was removed as vestigial
// multi-hotel-model plumbing that no longer did anything real).
const hotelId = process.env.NEWBOOK_LOCATION_ID || ''
const token = randomBytes(24).toString('hex')
const expiresAt = new Date(Date.now() + SESSION_TTL_MINUTES * 60 * 1000)