hotel-manage-stack/room-planner
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix past-departure room cards incorrectly merging with prior night

Browse source 
A past-departure record only marks that a checkout happened on the
viewed date — it never occupied the night before, so it must not
merge with the previous card the way a booking still actively
occupying viewDate would.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
jtricerolph 2026-08-06 14:11:40 +00:00
parent db38b586d5
commit 16c70f5ba4
1 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

10
backend/src/lib/booking-flow.js
View file

@ -89,6 +89,10 @@ export function classifyRoom(site, allBookings, viewDate, yesterday, tomorrow, o
// Determine flow type // Determine flow type
let flowType = 'vacant' let flowType = 'vacant'
// True when primaryBooking is a historical depart-only record (set below) rather
// than a booking that actually occupies viewDate — the room was vacant that night.
let isPastDepartureRecord = false
if (primaryBooking) { if (primaryBooking) {
const status = (primaryBooking.booking_status || '').toLowerCase() const status = (primaryBooking.booking_status || '').toLowerCase()
if (status === 'blocked') { if (status === 'blocked') {
@ -113,6 +117,7 @@ export function classifyRoom(site, allBookings, viewDate, yesterday, tomorrow, o
} else if (effectiveDeparting && opts.past) { } else if (effectiveDeparting && opts.past) {
primaryBooking = effectiveDeparting primaryBooking = effectiveDeparting
flowType = 'depart' flowType = 'depart'
isPastDepartureRecord = true
} }
const arrivalDate = primaryBooking ? toDateStr(primaryBooking.booking_arrival) : null const arrivalDate = primaryBooking ? toDateStr(primaryBooking.booking_arrival) : null
@ -158,7 +163,10 @@ export function classifyRoom(site, allBookings, viewDate, yesterday, tomorrow, o
flow_type: flowType, flow_type: flowType,
booking: primaryBooking, booking: primaryBooking,
spans_previous: isVacantFlow // A past-departure record only marks that a checkout happened on viewDate — it
// never occupied the night before viewDate, so it must not merge with the prior
// card the way a booking that's still actively occupying viewDate would.
spans_previous: (isVacantFlow || isPastDepartureRecord)
? prevVacant ? prevVacant
: !!primaryBooking && !!arrivalDate && arrivalDate < viewDate, : !!primaryBooking && !!arrivalDate && arrivalDate < viewDate,
spans_next: isVacantFlow ? nextVacant : spansNext, spans_next: isVacantFlow ? nextVacant : spansNext,