hotel-manage-stack/rates
1
0
Fork 0
Code Issues 3 Pull requests Projects Releases Packages Wiki Activity Actions

Fix IPRoyal Playwright auth: use separate fields not URL-embedded

Browse source 
URL-embedded credentials are silently dropped by Chromium for IPRoyal
(proxy auth never sent → every page.goto times out). Separate username/
password fields work correctly — IPRoyal responds to the 407 challenge
quickly so there is no latency penalty unlike DataImpulse (~14s).
DataImpulse keeps URL-embedded credentials to avoid that round-trip.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
jtricerolph 2026-07-10 02:55:13 +00:00
parent 2b55b0d6a5
commit 218589afbe
1 changed files with 10 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

16
backend/services/proxy.py
View file

@ -98,16 +98,20 @@ def _build_auth(cfg: dict, session_id: Optional[str] = None):
def playwright_proxy(cfg: dict, session_id: Optional[str] = None) -> Optional[dict]: def playwright_proxy(cfg: dict, session_id: Optional[str] = None) -> Optional[dict]:
"""Proxy dict for new_context(proxy=...). None when disabled. """Proxy dict for new_context(proxy=...). None when disabled.
Credentials are embedded in the server URL rather than passed as separate DataImpulse: credentials embedded in the server URL — separate fields cause
fields. Separate fields cause Chromium to wait for a 407 challenge before a ~14s 407 round-trip before DataImpulse issues a challenge.
sending auth — DataImpulse takes ~14s to issue that challenge, making every
page.goto() timeout. Embedded credentials are sent on the first CONNECT IPRoyal: separate username/password fields — URL-embedded credentials are
request, bypassing the round-trip entirely. not parsed correctly by Chromium for this provider (auth silently dropped).
IPRoyal responds to the 407 challenge quickly so there is no latency penalty.
""" """
if not is_enabled(cfg): if not is_enabled(cfg):
return None return None
from urllib.parse import quote
user, pwd = _build_auth(cfg, session_id) user, pwd = _build_auth(cfg, session_id)
server = f"http://{cfg['host']}:{cfg['port']}"
if _provider(cfg) == 'iproyal':
return {'server': server, 'username': user, 'password': pwd}
from urllib.parse import quote
return { return {
'server': f"http://{quote(user, safe='')}:{quote(pwd, safe='')}@{cfg['host']}:{cfg['port']}", 'server': f"http://{quote(user, safe='')}:{quote(pwd, safe='')}@{cfg['host']}:{cfg['port']}",
} }