hotel-manage-stack/kitchen
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix migration transaction poisoning: ADD COLUMN IF NOT EXISTS

Browse source 
Migrations used try/except around ADD COLUMN inside a single engine.begin()
block. When a 'column already exists' error was caught, asyncpg left the
transaction in aborted state, causing all subsequent DDL in the block to fail
with InFailedSQLTransactionError. Replace with IF NOT EXISTS to prevent the
error entirely.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
jtricerolph 2026-07-12 19:53:26 +00:00
parent e7e1fda9f6
commit bc874ac9ff
25 changed files with 302 additions and 302 deletions
Download patch file Download diff file Expand all files Collapse all files

8
backend/migrations/add_vat_rate_settings.py
View file

@ -18,8 +18,8 @@ async def run_migration():
# Add VAT rate columns to kitchen_settings table
settings_columns = [
"ALTER TABLE kitchen_settings ADD COLUMN newbook_breakfast_vat_rate NUMERIC(5, 4) DEFAULT 0.10",
"ALTER TABLE kitchen_settings ADD COLUMN newbook_dinner_vat_rate NUMERIC(5, 4) DEFAULT 0.10",
"ALTER TABLE kitchen_settings ADD COLUMN IF NOT EXISTS newbook_breakfast_vat_rate NUMERIC(5, 4) DEFAULT 0.10",
"ALTER TABLE kitchen_settings ADD COLUMN IF NOT EXISTS newbook_dinner_vat_rate NUMERIC(5, 4) DEFAULT 0.10",
]
for sql in settings_columns:
@ -36,8 +36,8 @@ async def run_migration():
# Add GL group columns to newbook_gl_accounts table (if not present)
gl_columns = [
"ALTER TABLE newbook_gl_accounts ADD COLUMN gl_group_id VARCHAR(50)",
"ALTER TABLE newbook_gl_accounts ADD COLUMN gl_group_name VARCHAR(255)",
"ALTER TABLE newbook_gl_accounts ADD COLUMN IF NOT EXISTS gl_group_id VARCHAR(50)",
"ALTER TABLE newbook_gl_accounts ADD COLUMN IF NOT EXISTS gl_group_name VARCHAR(255)",
]
for sql in gl_columns: