hotel-manage-stack/kitchen
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix migration transaction poisoning: ADD COLUMN IF NOT EXISTS

Browse source 
Migrations used try/except around ADD COLUMN inside a single engine.begin()
block. When a 'column already exists' error was caught, asyncpg left the
transaction in aborted state, causing all subsequent DDL in the block to fail
with InFailedSQLTransactionError. Replace with IF NOT EXISTS to prevent the
error entirely.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
jtricerolph 2026-07-12 19:53:26 +00:00
parent e7e1fda9f6
commit bc874ac9ff
25 changed files with 302 additions and 302 deletions
Download patch file Download diff file Expand all files Collapse all files

2
backend/migrations/add_cost_distributions.py
View file

@ -112,7 +112,7 @@ async def migrate():
# Add cost_distribution_max_days to kitchen_settings
try:
await conn.execute(text(
"ALTER TABLE kitchen_settings ADD COLUMN cost_distribution_max_days INTEGER DEFAULT 90"
"ALTER TABLE kitchen_settings ADD COLUMN IF NOT EXISTS cost_distribution_max_days INTEGER DEFAULT 90"
))
print("+ Added cost_distribution_max_days to kitchen_settings")
except Exception as e: